Comments on: Typo3: show login page for protected pages when user not is logged in http://blog.dev001.net/2009/10/typo3-show-login-page-for-protected-pages-when-user-not-is-logged-in/ Just another Web Developer's weblog Thu, 01 Jul 2010 12:09:46 +0000 hourly 1 http://wordpress.org/?v=3.0 By: Jörg Wagner http://blog.dev001.net/2009/10/typo3-show-login-page-for-protected-pages-when-user-not-is-logged-in/comment-page-1/#comment-2328 Jörg Wagner Thu, 01 Jul 2010 12:09:46 +0000 http://blog.dev001.net/?p=228#comment-2328 Very nice, Richard! I just implemented your solution in a TYPO3 4.3.2 website using the felogin sysext for logins and I had to change some details to get it working: 1. As I don’t use RealURL or static URLs in this project, my LOGIN_URL contains an id parameter. So, as there is already a parameter in the URL any further params have to be appended using & instead of ?. This results in the following code change: $url = LOGIN_URL.(strpos(LOGIN_URL, '?')===false?'?':'&')."redirect_url=".$param["currentUrl"]; Unfortunatelly this blog software heavily degrades the above code line. I hope you can figure it out as I dont know how to enter it so that is not corrupted. With a bit of PHP knowledge it should be obvious. Maybe Richard can correct it. 2. With felogin 1.3.0 in TYPO3 4.3.2 the redirect_url parameter is not correctly interpreted. This is a bug and it is corrected in TYPO3 4.4.0 (strange enough the sysext still has version 1.3.0 there!). To fix this problem in older versions of T3 do the following: In... /typo3/sysext/felogin/pi1/class.tx_felogin_pi1.php change this line... if (!$gpRedirectUrl && $this->redirectUrl && $this->logintype === ‘login’) { to this... if (!$gpRedirectUrl && $this->redirectUrl) { (delete the third condition entirely). 3. With felogin you have to set the redirect mode in the plugin settings to 'defined by GET/POST-Vars' to activate the interpretation of the redirect_url GET parameter. This also makes it possible to define the priority of different redirects. Thanks again for your nice work! Cheers, Jörg. Very nice, Richard!

I just implemented your solution in a TYPO3 4.3.2 website using the felogin sysext for logins and I had to change some details to get it working:

1. As I don’t use RealURL or static URLs in this project, my LOGIN_URL contains an id parameter. So, as there is already a parameter in the URL any further params have to be appended using & instead of ?.
This results in the following code change:
$url = LOGIN_URL.(strpos(LOGIN_URL, ‘?’)===false?’?’:’&’).”redirect_url=”.$param[“currentUrl”];
Unfortunatelly this blog software heavily degrades the above code line. I hope you can figure it out as I dont know how to enter it so that is not corrupted. With a bit of PHP knowledge it should be obvious. Maybe Richard can correct it.

2. With felogin 1.3.0 in TYPO3 4.3.2 the redirect_url parameter is not correctly interpreted. This is a bug and it is corrected in TYPO3 4.4.0 (strange enough the sysext still has version 1.3.0 there!). To fix this problem in older versions of T3 do the following:
In…
/typo3/sysext/felogin/pi1/class.tx_felogin_pi1.php
change this line…
if (!$gpRedirectUrl && $this->redirectUrl && $this->logintype === ‘login’) {
to this…
if (!$gpRedirectUrl && $this->redirectUrl) {
(delete the third condition entirely).

3. With felogin you have to set the redirect mode in the plugin settings to ‘defined by GET/POST-Vars’ to activate the interpretation of the redirect_url GET parameter. This also makes it possible to define the priority of different redirects.

Thanks again for your nice work!
Cheers, Jörg.

]]> By: Jörg Wagner http://blog.dev001.net/2009/10/typo3-show-login-page-for-protected-pages-when-user-not-is-logged-in/comment-page-1/#comment-2327 Jörg Wagner Thu, 01 Jul 2010 11:39:14 +0000 http://blog.dev001.net/?p=228#comment-2327 Oh damn - I am really flooding this thread - everything in German in the last posting was not meant to be posted. Please ignore / delete... Oh damn - I am really flooding this thread - everything in German in the last posting was not meant to be posted. Please ignore / delete…

]]> By: Jörg Wagner http://blog.dev001.net/2009/10/typo3-show-login-page-for-protected-pages-when-user-not-is-logged-in/comment-page-1/#comment-2326 Jörg Wagner Thu, 01 Jul 2010 11:38:02 +0000 http://blog.dev001.net/?p=228#comment-2326 Well, unfortunatelly this was not all. The param "referer" is unfortunatelly also used when calling the login page from some other page in the website. In this case my posted solution will redirect after login back to the calling page, which is not at all desireable. The final solution reverts back to redirect_url and I will send it in a separate posting, so Richard can delete all this intermediate stuff if he wishes. Here we go... dann wird nach dem Login fälschlicherweise dorthin zurück gekehrt. Also zurück zu redirect_url. Wie bereits in meinem ersten Posting vermutet, gibt es hier in felogin 1.3.0 einen Bug. Dieser ist in TYPO3 4.4.0 behoben (die Sysext trägt dort aber komischerweise immer noch die Versionsnummer 1.3.0). Um ihn in älteren T3-Versionen zu beheben: In /typo3/sysext/felogin/pi1/class.tx_felogin_pi1.php die Zeile if (!$gpRedirectUrl && $this->redirectUrl && $this->logintype === 'login') { ändern in if (!$gpRedirectUrl && $this->redirectUrl) { (also die dritte Condition löschen). Well, unfortunatelly this was not all.
The param “referer” is unfortunatelly also used when calling the login page from some other page in the website. In this case my posted solution will redirect after login back to the calling page, which is not at all desireable.
The final solution reverts back to redirect_url and I will send it in a separate posting, so Richard can delete all this intermediate stuff if he wishes. Here we go…
dann wird nach dem Login fälschlicherweise dorthin zurück gekehrt. Also zurück zu redirect_url. Wie bereits in meinem ersten Posting vermutet, gibt es hier in felogin 1.3.0 einen Bug. Dieser ist in TYPO3 4.4.0 behoben (die Sysext trägt dort aber komischerweise immer noch die Versionsnummer 1.3.0). Um ihn in älteren T3-Versionen zu beheben:
In
/typo3/sysext/felogin/pi1/class.tx_felogin_pi1.php
die Zeile
if (!$gpRedirectUrl && $this->redirectUrl && $this->logintype === ‘login’) {
ändern in
if (!$gpRedirectUrl && $this->redirectUrl) {
(also die dritte Condition löschen).

]]> By: Jörg Wagner http://blog.dev001.net/2009/10/typo3-show-login-page-for-protected-pages-when-user-not-is-logged-in/comment-page-1/#comment-2325 Jörg Wagner Thu, 01 Jul 2010 07:53:41 +0000 http://blog.dev001.net/?p=228#comment-2325 Hmmm. Wordpress heavily destroyed my code change line. I hope you can figure it out as I dont know how to enter it so that is not corrupted. With a bit of PHP knowledge it should be obvious. Maybe Richard can correct it. Cheers, Jörg. Hmmm. WordPress heavily destroyed my code change line. I hope you can figure it out as I dont know how to enter it so that is not corrupted. With a bit of PHP knowledge it should be obvious. Maybe Richard can correct it.
Cheers, Jörg.

]]> By: Jörg Wagner http://blog.dev001.net/2009/10/typo3-show-login-page-for-protected-pages-when-user-not-is-logged-in/comment-page-1/#comment-2324 Jörg Wagner Thu, 01 Jul 2010 07:46:41 +0000 http://blog.dev001.net/?p=228#comment-2324 Very nice, Richard! I just implemented your solution in a TYPO3 4.3.2 website using the felogin sysext for logins and I had to change some details to get it working: 1. As I don't use RealURL or static URLs in this project, my LOGIN_URL contains an id parameter. So, as there is already a parameter in the URL any further params have to be appended using & instead of ? (see code change below). 2. With felogin 1.3.0 the redirect_url parameter is not correctly interpreted. I am quite sure that this is a bug, but did not investigate this route. The better solution is to use the referrer parameter and in the felogin plugin settings set the redirect mode to \defined by Referrer\. This also makes it possible to define the priority of different redirects. Together with the change in 1. this results in the following code change: $url = LOGIN_URL.(strpos(LOGIN_URL, '?')===false?'?':'&').\referer=\.$param[\currentUrl\]; 3. VERY IMPORTANT: The current version 1.3.0 of felogin contains a bug which impedes the correct function of the referer param (see http://bugs.typo3.org/view.php?id=12990). To make it work you have to apply the latest patch in that bug report. It has been committed to trunk on 05/31/2010 so it will probably be part of the core in the next T3 versions. Thanks again for your nice work! Cheers, Jörg. Very nice, Richard!

I just implemented your solution in a TYPO3 4.3.2 website using the felogin sysext for logins and I had to change some details to get it working:

1. As I don’t use RealURL or static URLs in this project, my LOGIN_URL contains an id parameter. So, as there is already a parameter in the URL any further params have to be appended using & instead of ? (see code change below).

2. With felogin 1.3.0 the redirect_url parameter is not correctly interpreted. I am quite sure that this is a bug, but did not investigate this route. The better solution is to use the referrer parameter and in the felogin plugin settings set the redirect mode to \defined by Referrer. This also makes it possible to define the priority of different redirects. Together with the change in 1. this results in the following code change:
$url = LOGIN_URL.(strpos(LOGIN_URL, ‘?’)===false?’?’:’&’).\referer=.$param[\currentUrl\];

3. VERY IMPORTANT: The current version 1.3.0 of felogin contains a bug which impedes the correct function of the referer param (see http://bugs.typo3.org/view.php?id=12990). To make it work you have to apply the latest patch in that bug report. It has been committed to trunk on 05/31/2010 so it will probably be part of the core in the next T3 versions.

Thanks again for your nice work!
Cheers, Jörg.

]]>